MODE-1525 Adding a node without specifying primary type incorrectly assumed "nt:unstructured" #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssumed "nt:unstructured" If a parent has a child node definition with a default primary node type, and a child (with the correct name to match the child node definition) is added without specifying the primary type, the child incorrectly was assigned a primary type of "nt:unstructured". This was because the "AbstractJcrNode.addNode(String)" method incorrectly hard-coded the node type to "nt:unstructured" rather than determining the child's node type from the parent's node type(s). Simply removing this assumption fixes the problem. Two new tests were added to replicate this problem and verify the changes do correct the problem. All unit and integration tests pass with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a parent has a child node definition with a default primary node type, and a child (with the correct name to match the child node definition) is added without specifying the primary type, the child incorrectly was assigned a primary type of "nt:unstructured". This was because the "AbstractJcrNode.addNode(String)" method incorrectly hard-coded the node type to "nt:unstructured" rather than determining the child's node type from the parent's node type(s). Simply removing this assumption fixes the problem.
Two new tests were added to replicate this problem and verify the changes do correct the problem.
All unit and integration tests pass with these changes.