MODE-1291 Initial commit of Infinispan BinaryStore impl #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kosch
commented
Aug 10, 2012
kosch
commented
- replaced distributed executable with map reduce
- applied changes according MODE-1586
- Still open: integration into modeshape configuration
| protected long modificationTime; | ||
| protected long unusedSince; | ||
| protected String mimeType; | ||
| protected String extractedText; |
There was a problem hiding this comment.
The extracted text actually can be quite large. Why not store the extracted text in the same blob cache, just with slightly-modified keys (e.g., append "-text" to the binary key)?
|
Overall this looks really good. I would recommend changing the binary store to persist the extract text with the blobs rather than the metadata (since the extract text for a large binary value could be quite large itself). |
|
I've changed the storage of extracted text as suggested. As next I'll integrate the stuff into the configuration. |
|
Last open point: removal of unused stuff. Will be fixed shortly. |
- replaced distributed executable with map reduce - applied changes according MODE-1586 - Still open: integration into modeshape configuration MODE-1291 extracted text now stored as binary data
|
Its now ready to be pushed. I've to admit, that I do not have tested all combinations of cache configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.