MODE-1552 Corrected how Node.save() works with descendant shared nodes #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node.save() method is deprecated, but the behavior was incorrect when there were shared nodes below the node being saved and where the shared nodes were in the same shared set as nodes that were not descendants. This behavior was corrected while keeping Node.save() relatively efficient, although it's still not as efficient as a regular Session.save(). All TCK unit tests pass with these fixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.save() method is deprecated, but the behavior was incorrect when there were shared nodes below the node being saved and where the shared nodes were in the same shared set as nodes that were not descendants. This behavior was corrected while keeping Node.save() relatively efficient, although it's still not as efficient as a regular Session.save().
All TCK unit tests pass with these fixes!
This pull-request also contains some corrections for JavaDoc errors and compiler warnings introduced in recent commits.