MODE-1665 Corrected AS7.2 kit to deal with missing methods #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting this class led to several other problems, primarily with the logging system. In particular, we were no longer able to see the correct logging implementations and load the SLF4J logger, probably (big assumption here) because AS7.2 was changed to no longer leak the logging interfaces and implementations and thereby exposing some incorrect dependencies in ModeShape modules. Plus, our LoggerFactory class was attempting to discover the logger classes (for the various frameworks) using the thread context classloader (TCCL) and then the system classloader – but not the current classloader. This seems obviously incorrect, so this was changed to simply try to load the class with the current classloader. The same thing was done for JaasProvider, which was the only other class using the ClassUtil.loadClassStrict(...) method. After all these changes, full builds running the following commands pass: * mvn clean install -Pintegration * mvn clean install -Pintegration,as72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting the AS7.2 kit to correct the compiler problems led to several other problems, primarily with the logging system. In particular, we were no longer able to see the correct logging implementations and load the SLF4J logger, probably (big assumption here) because AS7.2 was changed to no longer leak the logging interfaces and implementations and thereby exposing some incorrect dependencies in ModeShape modules.
Plus, our LoggerFactory class was attempting to discover the logger classes (for the various frameworks) using the thread context classloader (TCCL) and then the system classloader – but not the current classloader. This seems obviously incorrect, so this was changed to simply try to load the class
with the current classloader. The same thing was done for JaasProvider, which was the only other class using the ClassUtil.loadClassStrict(...) method.
After all these changes, full builds running the following commands pass: