MODE-1141 Corrected VersionManager.checkin(...) logic to not duplicate ve #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e versionable nodes in history As noted in the JIRA issue, the JcrVersionManager.checkin(...) method calls the versionNodeAt(...) recursive method, which copies the versionable state into the new version in version history. This method should *not* be walking children when the child is 'mix:versionable' and has an OPV on the child node definition of VERSION. This change simply implements this behavior by returning from the method rather than breaking (the children are walked after the break). All unit and integration tests pass with this minor change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODE-1141 Corrected VersionManager.checkin(...) logic to not duplicate versionable nodes in history
As noted in the JIRA issue, the JcrVersionManager.checkin(...) method calls the versionNodeAt(...) recursive method, which copies the versionable state into the new version in version history. This method should not be walking children when the child is 'mix:versionable' and has an OPV on the child node definition of VERSION.
This change simply implements this behavior by returning from the method rather than breaking (the children are walked after the break).
All unit and integration tests pass with this minor change.