MODE-1699 Added separate limit for string storage in binary store #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a separate configuration field to set the minimum size for string values that should be stored in the binary store. This is separate from the existing 'minimumBinarySizeInBytes' value, though it will default to that 'minimumBinarySizeInBytes' value. All unit and integration tests pass.
Added support to the subsystem for AS7 to separately configure the minimum size of string values that are to be stored inside the binary store. Like with the regular JSON configuration, the minimum string size defaults to whatever the minimum binary size is.
|
Changes look good, the only thing that can be improved imo is described in the previous comment. |
|
Refactored the code. However, I wanted to keep the method abstract to require subclasses to implement it, so I moved the logic to a separate method in super. (Not exactly what you suggested, but certainly in the spirit.) |
|
yup, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a separate configuration field to set the minimum size for string values that should be stored in the binary store. This is separate from the existing 'minimumBinarySizeInBytes' value, though it will default to that 'minimumBinarySizeInBytes' value.
Added support to the subsystem for AS7 to separately configure the minimum size of string values that are to be stored inside the binary store. Like with the regular JSON configuration, the minimum string size defaults to whatever the minimum binary size is.
All unit and integration tests pass.