MODE-1844 - Improved error handling & recovery during startup, so that an exception does not leave the repository in inconsistent state #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t an exception does not leave the repository in inconsistent state
|
Merged into the 'master' brach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original thought for solving this was to use a start-up transaction which could be easily rolled back in case of an exception. However, this is not feasible since the whole point of the REPOSITORY_INFO_DOC was to notify other members in a potential cluster that one node is doing the initialization.
Therefore, using a long-running start-up transaction would not work, the whole point being that the document gets written to the persistent store ASAP.
The solution was to clean-up/improve exception handling and in the case of an unexpected error, remove the above mentioned document, if the node on which the error occurred was the node which started the initialization process.