MODE-1878 Corrected determination of correct SNS child node definitions #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node with a child is persisted, and then a new child node with the same name as the existing child is added to the parent, and when the parent node type contains more than one applicable residual child node definition, ModeShape incorrected determined that no child node definition could be found for the new SNS child. Two new test cases were added to replicate this scenario, and the validation logic was corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node with a child is persisted, and then a new child node with the same name as the existing child is added to the parent, and when the parent node type contains more than one applicable residual child node definition, ModeShape incorrected determined that no child node definition could be found for the new SNS child.
Two new test cases were added to replicate this scenario, and the validation logic was corrected.