Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODE-1880 FileSystemConnector uses incorrect ID when adding content to nt:file nodes #771

Merged
merged 1 commit into from Apr 4, 2013

Conversation

codebrewer
Copy link
Contributor

The local name was being used to prevent generation of filenames containing the : character, but this is unnecessary for jcr:content nodes since the content should end up on disk in the file associated with the nt:file ancestor node.

…o nt:file nodes

The local name was being used to prevent generation of filenames containing the : character, but this is unnecessary for jcr:content nodes since the content should end up on disk in the file associated with the nt:file ancestor node.
@rhauch
Copy link
Contributor

rhauch commented Apr 4, 2013

For future reference, be sure to do your work on a branch so that your changes are isolated, and then push your branch to your fork and create the pull-request. We sometimes need to modify the commits (usually because we need to rebase them on top of commits merged since you created your pull-request). If your master contains your commits and you fetched our (slightly-different) commits, your master branch can be different than ours.

Luckily, we can use these commits as-is, so this pull-request is fine.

@rhauch rhauch merged commit 057bab5 into ModeShape:master Apr 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants