Mode 1912 - Updated the logic behind mixin removal #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2013 11:08
…nd children when a mixin is removed from a node.
… removed and then later on re-added, the correct version history & properties are re-linked to that node.
|
Rebased and merged into the 'master' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mixin is removed from a node, all protected properties that are coming from that mixin will be removed as well.
However, this brought up a new issue: in the case of
mix:versionable, even though the properties are removed, the entire version history & lineage remain. Therefore, a code-update was needed in the versioning logic, so that ifmix:versionableis removed on a node and then later on re-added, the original references towards the version history, base version etc are re-constructed.