MODE-1091 JPA connector: Extension of JPA connector's configuration with #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith default DB schema Added a schemaName property to JpaSource, modified the Hibernate connection code as described in the JIRA issue, and updated the Reference Guide. Thanks are due to Dmitri for noting this and providing the fix!
| @@ -239,6 +242,11 @@ public class JpaSource implements RepositorySource, ObjectFactory { | |||
| @Category( i18n = JpaConnectorI18n.class, value = "passwordPropertyCategory" ) | |||
| private volatile String password; | |||
|
|
|||
| @Description( i18n = JpaConnectorI18n.class, value = "schemaNamePropertyDescription" ) | |||
| @Label( i18n = JpaConnectorI18n.class, value = "schemaNamePropertyLabel" ) | |||
| @Category( i18n = JpaConnectorI18n.class, value = "schemaNamePropertyCategory" ) | |||
There was a problem hiding this comment.
These I18n messages are not in the JpaConnectorI18n Java class and JpaConnectorI18n.properties file, are they?
There was a problem hiding this comment.
You're right. Thanks for catching that, I'll correct and re-push.
…ith default DB schema Added missing I18n fields and values. Thanks for catching that, Randall!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODE-1091 JPA connector: Extension of JPA connector's configuration with default DB schema
Added a schemaName property to JpaSource, modified the Hibernate connection code as described in the JIRA issue, and updated the Reference Guide.
Thanks are due to Dmitri for noting this and providing the fix!