MODE-1155 Added test to verify I18n messages exist for related annotations #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Added several unit tests that check the existence and validity of I18n constants and messages for all annotations referencing them. These annotations, such as @Label, @description, and @category, reference the I18n messages by string value rather than I18n reference. Note that a helper method was added to the AbstractI18nTest that is used in each module that uses I18n constants. This allows test methods to be easily added for any object that has such annotations. Adding these tests pointed out quite a few mismatches between the string values and the I18n message keys. These were corrected, and all unit and integration tests now pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several unit tests that check the existence and validity of I18n constants and messages for all annotations referencing them. These annotations, such as @Label, @description, and @category, reference the I18n messages by string value rather than I18n reference.
Note that a helper method was added to the AbstractI18nTest that is used in each module that uses I18n constants. This allows test methods to be easily added for any object that has such annotations.
Adding these tests pointed out quite a few mismatches between the string values and the I18n message keys. These were corrected, and all unit and integration tests now pass.