MODE-1943 Implemented peer-to-peer indexing, based on processing of remote internal events. #827
Conversation
…emote internal events. This mechanism will be triggered whenever a repository is clustered and indexing is not configured in clustered mode.
| @@ -56,7 +55,7 @@ void addToIndex( String workspace, | |||
| Path path, | |||
| Name primaryType, | |||
| Set<Name> mixinTypes, | |||
| Collection<Property> properties, | |||
| Iterator<Property> propertiesIterator, | |||
There was a problem hiding this comment.
I'm curious why you made this change. It does appear to simplify implementations very slightly (since they don't have to actually call iterator(), but since the supplied iterator can only be used once it means that it will no longer work if there are multiple monitors.
There was a problem hiding this comment.
The reason for the change is that the CachedNode interfaces expose node properties as iterators as opposed to collections. Therefore, when passing those properties to the monitor for indexing (in the case of remote events) I would've had to collect them in a collection - which would've been a performance issue (given the frequency of remote events in a cluster)
I do agree with the point about multiple monitors, but IMO given the way we use monitors atm, it doesn't seem likely that we'll have multiple monitors operating on the same set of properties. If sometime in the future this will be the case, we can easily add an overloaded method.
|
Everything looks good. I'll begin the merge. |
|
Rebased and merged into the 'master' branch. |
This mechanism will be triggered whenever a repository is clustered and indexing is not configured in clustered mode.