MODE-1719 AS7 subsystem should expose monitoring information via management layer #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gement layer Added to the JBoss subsystem the ability to gather metrics using the RepositoryStatistics provided by the JcrRepository.
…gement layer Added to the JBoss subsystem the ability to gather metrics using the RepositoryStatistics provided by the JcrRepository.
…gement layer Now creating an instance of each metric for each window duration. Also, the monitor service no longer logs into the repository. So until the repository is started the metric values will be "undefined" when the runtime value is requested. Now using the interface type of RepositoryMonitor instead of RepositoryStatistics.
|
Tested this in EAP and verified in CLI. All looks good. |
|
Merged the second pull-request into the 'master' branch, and cherry-picked all 4 commits onto the '3.3.x' branch (since this is needed by the RHQ plugin that is still under development but needed for the products). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is a simplification of and thus supersedes the original pull-request.
Added to the JBoss subsystem the ability to gather metrics using the RepositoryStatistics provided by the JcrRepository.
Now creating 5 AS metrics (one for each window duration) for each repository metric. Changed the type from RepositoryStatistics to the interface RepositoryMonitor in the classes that needed the metrics. No longer logging in to the repository during MonitorService.start(). So metric runtime values will be "undefined" until the repository starts. Here are some other things of note:
Changed a spelling error in Window.PREVIOUS_52_WEEKS literal. From "previous-52-wees" to "previous-52-weeks."
Created constants in the interfaces of History, Statistics, RepositoryMonitor, and DurationActivity for empty or no values of these types. Some of these constants I moved from RepositoryStatistics. Also renamed the RepositoryStatistics implementations of these interfaces.