MODE-2009 Fixed the workspace.delete() operation #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns are being checked and b) the workspace is actually cleared and all nodes removed. This also exposed an additional problem regarding the retrieval of all the additional parents of a node.
|
Merged into the 'master' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is made up of
a) checking of WORKSPACE_DELETE permissions
b) making sure the workspace is actually cleared and all nodes removed.
This last part was extremely tricky to implement because we need to be sure that everything is done atomically. It also exposed an additional problem regarding the retrieval of all the additional parents of a node.