MODE-2042: Test permissions for principals known to the security context #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (hasPrivs) { | ||
| return true; | ||
| } | ||
| res |= ace.hasPrivileges(privileges); |
There was a problem hiding this comment.
If res is true at this point, can't we return without checking anything else? Or, perhaps the remaining if blocks should first check for !res? (IMO, the former is a tad more efficient and possibly a bit easier to see when just scanning the code, but the latter is not really too bad, either.)
|
Updated with respect to comments plus test case |
|
Rebased and merged into the 'master' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies logic for permissions checking procedure. Originally only user id was used and in this version the entire security context and thus all principals are involved into the testing process.