Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to calculate oscillation based measures #267

Closed
pbiecek opened this issue Jul 23, 2020 · 1 comment
Closed

Make it easier to calculate oscillation based measures #267

pbiecek opened this issue Jul 23, 2020 · 1 comment
Assignees
@pbiecek
Labels
feature 💡 New feature or enhancement request R 🐳 Related to R

Comments

@pbiecek
Copy link
Member

pbiecek commented Jul 23, 2020

Now the model_parts function allows you to use type="oscillations" to calculate variable importance based on the oscillations. But using this option is still a hassle, because the user has to choose split_variables to determine the density for each variable.

Suggestion:
add type="oscillations_uni" and type="oscillations_emp" which will automatically set the distributions of variables themselves.

This will not change the default behaviour and will facilitate the use of both oscillation-related measures
@pbiecek pbiecek added feature 💡 New feature or enhancement request R 🐳 Related to R labels Jul 23, 2020
@pbiecek pbiecek self-assigned this Jul 23, 2020
pbiecek added a commit that referenced this issue Jul 23, 2020
@pbiecek
candidate fix for #267. No changes in default behaviour
4852d5e
@pbiecek
Copy link
Member Author

pbiecek commented Jul 26, 2020

fixed in 4852d5e

@pbiecek pbiecek closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbiecek pbiecek

Labels
feature 💡 New feature or enhancement request R 🐳 Related to R
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbiecek