Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default color theme in DALEX #541

Closed
pbiecek opened this issue Jan 15, 2023 · 1 comment
Closed

Default color theme in DALEX #541

pbiecek opened this issue Jan 15, 2023 · 1 comment
Assignees
@pbiecek
Labels
documentation 📚 Improvements or additions to documentation feature 💡 New feature or enhancement request R 🐳 Related to R

Comments

@pbiecek
Copy link
Member

pbiecek commented Jan 15, 2023 •
edited
Loading

Currently the default theme is theme_drwhy for some plots and theme_drwhy_vertical for others.
Moreover the ggplot2::set_theme() will not work for most plots.
This may be problematic for some content, especially B&W books.

Request:
add new function DALEX::set_theme_dalex that will set default themes in a global way (through internal package variables)
@pbiecek pbiecek added feature 💡 New feature or enhancement request documentation 📚 Improvements or additions to documentation R 🐳 Related to R labels Jan 15, 2023
@pbiecek pbiecek self-assigned this Jan 15, 2023
@pbiecek pbiecek mentioned this issue Jan 15, 2023
Open
pbiecek added a commit that referenced this issue Jan 15, 2023
@pbiecek
#541 new functions with default themes
933f947
pbiecek added a commit to ModelOriented/iBreakDown that referenced this issue Jan 15, 2023
@pbiecek
candidate fix for ModelOriented/DALEX#541
557fa9c
@pbiecek
Copy link
Member Author

pbiecek commented Jan 26, 2023

working like a charm

@pbiecek pbiecek closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbiecek pbiecek

Labels
documentation 📚 Improvements or additions to documentation feature 💡 New feature or enhancement request R 🐳 Related to R
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbiecek