Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notes #130

Closed
hbaniecki opened this issue Aug 29, 2020 · 1 comment · Fixed by #133
Closed

notes #130

hbaniecki opened this issue Aug 29, 2020 · 1 comment · Fixed by #133
Labels
maintenance 🔨 Code enhancements, tests and maintenance

Comments

@hbaniecki
Copy link
Member

  • attr(x, 'observation') is used instead of attr(x, 'observations') in cp plot and ap
  • size=2 is not used in categorical cp plot but remains as default function value
@hbaniecki hbaniecki added the maintenance 🔨 Code enhancements, tests and maintenance label Aug 29, 2020
@pbiecek
Copy link
Member

pbiecek commented Aug 29, 2020

Lets fix these things after v 2.0

@hbaniecki hbaniecki mentioned this issue Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance 🔨 Code enhancements, tests and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

code and doc maintenance ModelOriented/ingredients
2 participants
@pbiecek @hbaniecki