code and doc maintenance #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #134 |
pbiecek
reviewed
Nov 12, 2020
| #' | ||
| #' | ||
| #' explain_titanic_rf <- explain(model_titanic_rf, | ||
| #' data = titanic_imputed[,-8], | ||
| #' y = titanic_imputed[,8], | ||
| #' label = "Random Forest v7", |
There was a problem hiding this comment.
why this label is removed? it can be changed to Ranger v7
There was a problem hiding this comment.
I hope that "ranger forest" is ok. (edited all examples)
vignettes/vignette_titanic.Rmd
Outdated
| @@ -21,11 +21,11 @@ knitr::opts_chunk$set( | |||
| # Data for Titanic survival | |||
|
|
|||
| Let's see an example for `DALEX` package for classification models for the survival problem for Titanic dataset. | |||
| Here we are using a dataset `titanic` avaliable in the `DALEX` package. Note that this data was copied from the `stablelearner` package. | |||
| Here we are using a dataset `titanic_imputed` avaliable in the `DALEX` package. | |||
There was a problem hiding this comment.
let's keep here an information about the source (stablelearner) of the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #130 closes #131 fixes #134
aut -> ctb
randomForest->rangertitanic->titanic_imputed