Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTE in winbuilder #149

Closed
pbiecek opened this issue Jan 14, 2023 · 0 comments
Closed

NOTE in winbuilder #149

pbiecek opened this issue Jan 14, 2023 · 0 comments
Labels
before release 📌 TODO before release bug 💣 Bug to fix

Comments

@pbiecek
Copy link
Member

pbiecek commented Jan 14, 2023

* checking R code for possible problems ... [10s] NOTE
Found if() conditions comparing class() to string:
File 'ingredients/R/aggregate_profiles.R': if (class(all_profiles) != "data.frame") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (!class(variables) == "character") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (class(x[, "_x_"]) == "numeric") ...
File 'ingredients/R/describe_aggregated_profiles.R': if (class(df[, variables]) == "factor" | class(df[, variables]) == "character") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (!class(variables) == "character") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (class(x[, variables]) == "numeric") ...
File 'ingredients/R/describe_ceteris_paribus.R': if (class(df[, variables]) == "factor" | class(df[, variables]) == "character") ...
File 'ingredients/R/describe_feature_importance.R': if (!(class(nonsignificance_treshold) == "numeric")) ...
Use inherits() (or maybe is()) instead.
@pbiecek pbiecek added bug 💣 Bug to fix before release 📌 TODO before release labels Jan 14, 2023
pbiecek added a commit that referenced this issue Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before release 📌 TODO before release bug 💣 Bug to fix
Projects
None yet
Development

No branches or pull requests

1 participant