Fix drop = FALSE to drop = TRUE

NEWS.md

@@ -14,7 +14,7 @@
 ## Bug fixes
 
 - `sv_dependence2D()`: In case `add_vars` are passed, `x` and/or `y` are removed from it in order to not use any variable twice. [#116](https://github.com/ModelOriented/shapviz/pull/116).
-- `split.shapviz()` now drops empty levels. They launched an error because empty "shapviz" objects are currently not supported. [#117](https://github.com/ModelOriented/shapviz/pull/117)
+- `split.shapviz()` now drops empty levels. They launched an error because empty "shapviz" objects are currently not supported. [#117](https://github.com/ModelOriented/shapviz/pull/117), [#118](https://github.com/ModelOriented/shapviz/pull/118)
 
 # shapviz 0.9.2
 

R/methods.R

@@ -354,8 +354,8 @@ c.shapviz <- function(...) {
 #'
 #' @param x Object of class "shapviz".
 #' @param f Vector used to split feature values and SHAP (interaction) values.
-#' @param ... Arguments passed to `split()`. Don't pass `drop = TRUE` as empty
-#'   "shapviz" objects are rejected.
+#'   Empty factor levels are dropped.
+#' @param ... Arguments passed to `split()`.
 #' @returns A "mshapviz" object.
 #' @examples
 #' \dontrun{
@@ -368,7 +368,7 @@ c.shapviz <- function(...) {
 #' @export
 #' @seealso [shapviz()], [rbind.shapviz()]
 split.shapviz <- function(x, f, ...) {
-  ind <- split(seq_len(nrow(x)), f = f, drop = FALSE, ...)
+  ind <- split(seq_len(nrow(x)), f = f, drop = TRUE, ...)
   mshapviz(lapply(ind, function(i) x[i, ]))
 }