fix: use default base url if BASE_URL env var is blank (#316)

Previously, a blank BASE_URL environment variable would cause an invalid URL error. Now it uses the default.

src/core.ts

@@ -953,14 +953,16 @@ export const ensurePresent = <T>(value: T | null | undefined): T => {
 /**
  * Read an environment variable.
  *
+ * Trims beginning and trailing whitespace.
+ *
  * Will return undefined if the environment variable doesn't exist or cannot be accessed.
  */
 export const readEnv = (env: string): string | undefined => {
   if (typeof process !== 'undefined') {
-    return process.env?.[env] ?? undefined;
+    return process.env?.[env]?.trim() ?? undefined;
   }
   if (typeof Deno !== 'undefined') {
-    return Deno.env?.get?.(env);
+    return Deno.env?.get?.(env)?.trim();
   }
   return undefined;
 };

src/index.ts

@@ -127,7 +127,7 @@ export class ModernTreasury extends Core.APIClient {
       organizationId,
       webhookKey,
       ...opts,
-      baseURL: baseURL ?? `https://app.moderntreasury.com`,
+      baseURL: baseURL || `https://app.moderntreasury.com`,
     };
 
     super({

tests/index.test.ts

@@ -148,7 +148,7 @@ describe('instantiate client', () => {
     });
 
     afterEach(() => {
-      process.env['SINK_BASE_URL'] = undefined;
+      process.env['MODERN_TREASURY_BASE_URL'] = undefined;
     });
 
     test('explicit option', () => {
@@ -165,6 +165,18 @@ describe('instantiate client', () => {
       const client = new ModernTreasury({ apiKey: 'My API Key', organizationId: 'my-organization-ID' });
       expect(client.baseURL).toEqual('https://example.com/from_env');
     });
+
+    test('empty env variable', () => {
+      process.env['MODERN_TREASURY_BASE_URL'] = ''; // empty
+      const client = new ModernTreasury({ apiKey: 'My API Key', organizationId: 'my-organization-ID' });
+      expect(client.baseURL).toEqual('https://app.moderntreasury.com');
+    });
+
+    test('blank env variable', () => {
+      process.env['MODERN_TREASURY_BASE_URL'] = '  '; // blank
+      const client = new ModernTreasury({ apiKey: 'My API Key', organizationId: 'my-organization-ID' });
+      expect(client.baseURL).toEqual('https://app.moderntreasury.com');
+    });
   });
 
   test('maxRetries option is correctly set', () => {