fix(client): eliminate circular imports, which cause runtime errors i…

…n webpack dev bundles (#249)

api.md

@@ -96,7 +96,7 @@ Methods:
 - <code title="get /api/incoming_payment_details/{id}">client.incomingPaymentDetails.<a href="./src/resources/incoming-payment-details.ts">retrieve</a>(id) -> IncomingPaymentDetail</code>
 - <code title="patch /api/incoming_payment_details/{id}">client.incomingPaymentDetails.<a href="./src/resources/incoming-payment-details.ts">update</a>(id, { ...params }) -> IncomingPaymentDetail</code>
 - <code title="get /api/incoming_payment_details">client.incomingPaymentDetails.<a href="./src/resources/incoming-payment-details.ts">list</a>({ ...params }) -> IncomingPaymentDetailsPage</code>
-- <code title="post /api/simulations/incoming_payment_details/create_async">client.incomingPaymentDetails.<a href="./src/resources/incoming-payment-details.ts">createAsync</a>({ ...params }) -> Shared.AsyncResponse</code>
+- <code title="post /api/simulations/incoming_payment_details/create_async">client.incomingPaymentDetails.<a href="./src/resources/incoming-payment-details.ts">createAsync</a>({ ...params }) -> AsyncResponse</code>
 
 # Invoices
 
@@ -387,7 +387,7 @@ Methods:
 - <code title="get /api/payment_orders/{id}">client.paymentOrders.<a href="./src/resources/payment-orders/payment-orders.ts">retrieve</a>(id) -> PaymentOrder</code>
 - <code title="patch /api/payment_orders/{id}">client.paymentOrders.<a href="./src/resources/payment-orders/payment-orders.ts">update</a>(id, { ...params }) -> PaymentOrder</code>
 - <code title="get /api/payment_orders">client.paymentOrders.<a href="./src/resources/payment-orders/payment-orders.ts">list</a>({ ...params }) -> PaymentOrdersPage</code>
-- <code title="post /api/payment_orders/create_async">client.paymentOrders.<a href="./src/resources/payment-orders/payment-orders.ts">createAsync</a>({ ...params }) -> Shared.AsyncResponse</code>
+- <code title="post /api/payment_orders/create_async">client.paymentOrders.<a href="./src/resources/payment-orders/payment-orders.ts">createAsync</a>({ ...params }) -> AsyncResponse</code>
 
 ## Reversals
 

src/resources/account-collection-flows.ts

@@ -3,8 +3,8 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import * as AccountCollectionFlowsAPI from 'modern-treasury/resources/account-collection-flows';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class AccountCollectionFlows extends APIResource {
   /**
@@ -80,8 +80,6 @@ export class AccountCollectionFlows extends APIResource {
 }
 
 export class AccountCollectionFlowsPage extends Page<AccountCollectionFlow> {}
-// alias so we can export it in the namespace
-type _AccountCollectionFlowsPage = AccountCollectionFlowsPage;
 
 export interface AccountCollectionFlow {
   /**
@@ -192,9 +190,9 @@ export interface AccountCollectionFlowListParams extends PageParams {
 }
 
 export namespace AccountCollectionFlows {
-  export import AccountCollectionFlow = API.AccountCollectionFlow;
-  export type AccountCollectionFlowsPage = _AccountCollectionFlowsPage;
-  export import AccountCollectionFlowCreateParams = API.AccountCollectionFlowCreateParams;
-  export import AccountCollectionFlowUpdateParams = API.AccountCollectionFlowUpdateParams;
-  export import AccountCollectionFlowListParams = API.AccountCollectionFlowListParams;
+  export type AccountCollectionFlow = AccountCollectionFlowsAPI.AccountCollectionFlow;
+  export import AccountCollectionFlowsPage = AccountCollectionFlowsAPI.AccountCollectionFlowsPage;
+  export type AccountCollectionFlowCreateParams = AccountCollectionFlowsAPI.AccountCollectionFlowCreateParams;
+  export type AccountCollectionFlowUpdateParams = AccountCollectionFlowsAPI.AccountCollectionFlowUpdateParams;
+  export type AccountCollectionFlowListParams = AccountCollectionFlowsAPI.AccountCollectionFlowListParams;
 }

src/resources/account-details.ts

@@ -3,9 +3,9 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
+import * as AccountDetailsAPI from 'modern-treasury/resources/account-details';
 import * as Shared from 'modern-treasury/resources/shared';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class AccountDetails extends APIResource {
   /**
@@ -89,8 +89,6 @@ export class AccountDetails extends APIResource {
 }
 
 export class AccountDetailsPage extends Page<AccountDetail> {}
-// alias so we can export it in the namespace
-type _AccountDetailsPage = AccountDetailsPage;
 
 export interface AccountDetail {
   id: string;
@@ -142,8 +140,8 @@ export interface AccountDetailCreateParams {
 export interface AccountDetailListParams extends PageParams {}
 
 export namespace AccountDetails {
-  export import AccountDetail = API.AccountDetail;
-  export type AccountDetailsPage = _AccountDetailsPage;
-  export import AccountDetailCreateParams = API.AccountDetailCreateParams;
-  export import AccountDetailListParams = API.AccountDetailListParams;
+  export type AccountDetail = AccountDetailsAPI.AccountDetail;
+  export import AccountDetailsPage = AccountDetailsAPI.AccountDetailsPage;
+  export type AccountDetailCreateParams = AccountDetailsAPI.AccountDetailCreateParams;
+  export type AccountDetailListParams = AccountDetailsAPI.AccountDetailListParams;
 }

src/resources/connections.ts

@@ -3,8 +3,8 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import * as ConnectionsAPI from 'modern-treasury/resources/connections';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class Connections extends APIResource {
   /**
@@ -27,8 +27,6 @@ export class Connections extends APIResource {
 }
 
 export class ConnectionsPage extends Page<Connection> {}
-// alias so we can export it in the namespace
-type _ConnectionsPage = ConnectionsPage;
 
 export interface Connection {
   id: string;
@@ -76,7 +74,7 @@ export interface ConnectionListParams extends PageParams {
 }
 
 export namespace Connections {
-  export import Connection = API.Connection;
-  export type ConnectionsPage = _ConnectionsPage;
-  export import ConnectionListParams = API.ConnectionListParams;
+  export type Connection = ConnectionsAPI.Connection;
+  export import ConnectionsPage = ConnectionsAPI.ConnectionsPage;
+  export type ConnectionListParams = ConnectionsAPI.ConnectionListParams;
 }

src/resources/counterparties.ts

@@ -3,11 +3,11 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as AccountDetails from 'modern-treasury/resources/account-details';
-import * as ExternalAccounts from 'modern-treasury/resources/external-accounts';
-import * as RoutingDetails from 'modern-treasury/resources/routing-details';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import * as CounterpartiesAPI from 'modern-treasury/resources/counterparties';
+import * as AccountDetailsAPI from 'modern-treasury/resources/account-details';
+import * as ExternalAccountsAPI from 'modern-treasury/resources/external-accounts';
+import * as RoutingDetailsAPI from 'modern-treasury/resources/routing-details';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class Counterparties extends APIResource {
   /**
@@ -107,8 +107,6 @@ export class Counterparties extends APIResource {
 }
 
 export class CounterpartiesPage extends Page<Counterparty> {}
-// alias so we can export it in the namespace
-type _CounterpartiesPage = CounterpartiesPage;
 
 export interface Counterparty {
   id: string;
@@ -164,12 +162,12 @@ export namespace Counterparty {
   export interface Account {
     id?: string;
 
-    account_details?: Array<AccountDetails.AccountDetail>;
+    account_details?: Array<AccountDetailsAPI.AccountDetail>;
 
     /**
      * Can be `checking`, `savings` or `other`.
      */
-    account_type?: ExternalAccounts.ExternalAccountType;
+    account_type?: ExternalAccountsAPI.ExternalAccountType;
 
     contact_details?: Array<Account.ContactDetail>;
 
@@ -218,7 +216,7 @@ export namespace Counterparty {
      */
     party_type?: 'business' | 'individual' | null;
 
-    routing_details?: Array<RoutingDetails.RoutingDetail>;
+    routing_details?: Array<RoutingDetailsAPI.RoutingDetail>;
 
     updated_at?: string;
 
@@ -376,7 +374,7 @@ export namespace CounterpartyCreateParams {
     /**
      * Can be `checking`, `savings` or `other`.
      */
-    account_type?: ExternalAccounts.ExternalAccountType;
+    account_type?: ExternalAccountsAPI.ExternalAccountType;
 
     contact_details?: Array<Account.ContactDetail>;
 
@@ -687,11 +685,11 @@ export interface CounterpartyCollectAccountParams {
 }
 
 export namespace Counterparties {
-  export import Counterparty = API.Counterparty;
-  export import CounterpartyCollectAccountResponse = API.CounterpartyCollectAccountResponse;
-  export type CounterpartiesPage = _CounterpartiesPage;
-  export import CounterpartyCreateParams = API.CounterpartyCreateParams;
-  export import CounterpartyUpdateParams = API.CounterpartyUpdateParams;
-  export import CounterpartyListParams = API.CounterpartyListParams;
-  export import CounterpartyCollectAccountParams = API.CounterpartyCollectAccountParams;
+  export type Counterparty = CounterpartiesAPI.Counterparty;
+  export type CounterpartyCollectAccountResponse = CounterpartiesAPI.CounterpartyCollectAccountResponse;
+  export import CounterpartiesPage = CounterpartiesAPI.CounterpartiesPage;
+  export type CounterpartyCreateParams = CounterpartiesAPI.CounterpartyCreateParams;
+  export type CounterpartyUpdateParams = CounterpartiesAPI.CounterpartyUpdateParams;
+  export type CounterpartyListParams = CounterpartiesAPI.CounterpartyListParams;
+  export type CounterpartyCollectAccountParams = CounterpartiesAPI.CounterpartyCollectAccountParams;
 }

src/resources/documents.ts

@@ -3,9 +3,9 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as API from './index';
+import * as DocumentsAPI from 'modern-treasury/resources/documents';
 import { type Uploadable, multipartFormRequestOptions } from 'modern-treasury/core';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class Documents extends APIResource {
   /**
@@ -53,8 +53,6 @@ export class Documents extends APIResource {
 }
 
 export class DocumentsPage extends Page<Document> {}
-// alias so we can export it in the namespace
-type _DocumentsPage = DocumentsPage;
 
 export interface Document {
   id: string;
@@ -205,8 +203,8 @@ export interface DocumentListParams extends PageParams {
 }
 
 export namespace Documents {
-  export import Document = API.Document;
-  export type DocumentsPage = _DocumentsPage;
-  export import DocumentCreateParams = API.DocumentCreateParams;
-  export import DocumentListParams = API.DocumentListParams;
+  export type Document = DocumentsAPI.Document;
+  export import DocumentsPage = DocumentsAPI.DocumentsPage;
+  export type DocumentCreateParams = DocumentsAPI.DocumentCreateParams;
+  export type DocumentListParams = DocumentsAPI.DocumentListParams;
 }

src/resources/events.ts

@@ -3,8 +3,8 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import * as EventsAPI from 'modern-treasury/resources/events';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class Events extends APIResource {
   /**
@@ -31,8 +31,6 @@ export class Events extends APIResource {
 }
 
 export class EventsPage extends Page<Event> {}
-// alias so we can export it in the namespace
-type _EventsPage = EventsPage;
 
 export interface Event {
   id: string;
@@ -94,7 +92,7 @@ export interface EventListParams extends PageParams {
 }
 
 export namespace Events {
-  export import Event = API.Event;
-  export type EventsPage = _EventsPage;
-  export import EventListParams = API.EventListParams;
+  export type Event = EventsAPI.Event;
+  export import EventsPage = EventsAPI.EventsPage;
+  export type EventListParams = EventsAPI.EventListParams;
 }

src/resources/expected-payments.ts

@@ -3,9 +3,9 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
+import * as ExpectedPaymentsAPI from 'modern-treasury/resources/expected-payments';
 import * as Shared from 'modern-treasury/resources/shared';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class ExpectedPayments extends APIResource {
   /**
@@ -83,8 +83,6 @@ export class ExpectedPayments extends APIResource {
 }
 
 export class ExpectedPaymentsPage extends Page<ExpectedPayment> {}
-// alias so we can export it in the namespace
-type _ExpectedPaymentsPage = ExpectedPaymentsPage;
 
 export interface ExpectedPayment {
   id: string;
@@ -512,10 +510,10 @@ export interface ExpectedPaymentListParams extends PageParams {
 }
 
 export namespace ExpectedPayments {
-  export import ExpectedPayment = API.ExpectedPayment;
-  export import ExpectedPaymentType = API.ExpectedPaymentType;
-  export type ExpectedPaymentsPage = _ExpectedPaymentsPage;
-  export import ExpectedPaymentCreateParams = API.ExpectedPaymentCreateParams;
-  export import ExpectedPaymentUpdateParams = API.ExpectedPaymentUpdateParams;
-  export import ExpectedPaymentListParams = API.ExpectedPaymentListParams;
+  export type ExpectedPayment = ExpectedPaymentsAPI.ExpectedPayment;
+  export type ExpectedPaymentType = ExpectedPaymentsAPI.ExpectedPaymentType;
+  export import ExpectedPaymentsPage = ExpectedPaymentsAPI.ExpectedPaymentsPage;
+  export type ExpectedPaymentCreateParams = ExpectedPaymentsAPI.ExpectedPaymentCreateParams;
+  export type ExpectedPaymentUpdateParams = ExpectedPaymentsAPI.ExpectedPaymentUpdateParams;
+  export type ExpectedPaymentListParams = ExpectedPaymentsAPI.ExpectedPaymentListParams;
 }

src/resources/external-accounts.ts

@@ -3,11 +3,11 @@
 import * as Core from 'modern-treasury/core';
 import { APIResource } from 'modern-treasury/resource';
 import { isRequestOptions } from 'modern-treasury/core';
-import * as AccountDetails from 'modern-treasury/resources/account-details';
-import * as RoutingDetails from 'modern-treasury/resources/routing-details';
+import * as ExternalAccountsAPI from 'modern-treasury/resources/external-accounts';
+import * as AccountDetailsAPI from 'modern-treasury/resources/account-details';
+import * as RoutingDetailsAPI from 'modern-treasury/resources/routing-details';
 import * as Shared from 'modern-treasury/resources/shared';
-import * as API from './index';
-import { Page, PageParams } from 'modern-treasury/pagination';
+import { Page, type PageParams } from 'modern-treasury/pagination';
 
 export class ExternalAccounts extends APIResource {
   /**
@@ -141,13 +141,11 @@ export class ExternalAccounts extends APIResource {
 }
 
 export class ExternalAccountsPage extends Page<ExternalAccount> {}
-// alias so we can export it in the namespace
-type _ExternalAccountsPage = ExternalAccountsPage;
 
 export interface ExternalAccount {
   id: string;
 
-  account_details: Array<AccountDetails.AccountDetail>;
+  account_details: Array<AccountDetailsAPI.AccountDetail>;
 
   /**
    * Can be `checking`, `savings` or `other`.
@@ -203,7 +201,7 @@ export interface ExternalAccount {
    */
   party_type: 'business' | 'individual' | null;
 
-  routing_details: Array<RoutingDetails.RoutingDetail>;
+  routing_details: Array<RoutingDetailsAPI.RoutingDetail>;
 
   updated_at: string;
 
@@ -611,12 +609,13 @@ export interface ExternalAccountVerifyParams {
 }
 
 export namespace ExternalAccounts {
-  export import ExternalAccount = API.ExternalAccount;
-  export import ExternalAccountType = API.ExternalAccountType;
-  export type ExternalAccountsPage = _ExternalAccountsPage;
-  export import ExternalAccountCreateParams = API.ExternalAccountCreateParams;
-  export import ExternalAccountUpdateParams = API.ExternalAccountUpdateParams;
-  export import ExternalAccountListParams = API.ExternalAccountListParams;
-  export import ExternalAccountCompleteVerificationParams = API.ExternalAccountCompleteVerificationParams;
-  export import ExternalAccountVerifyParams = API.ExternalAccountVerifyParams;
+  export type ExternalAccount = ExternalAccountsAPI.ExternalAccount;
+  export type ExternalAccountType = ExternalAccountsAPI.ExternalAccountType;
+  export import ExternalAccountsPage = ExternalAccountsAPI.ExternalAccountsPage;
+  export type ExternalAccountCreateParams = ExternalAccountsAPI.ExternalAccountCreateParams;
+  export type ExternalAccountUpdateParams = ExternalAccountsAPI.ExternalAccountUpdateParams;
+  export type ExternalAccountListParams = ExternalAccountsAPI.ExternalAccountListParams;
+  export type ExternalAccountCompleteVerificationParams =
+    ExternalAccountsAPI.ExternalAccountCompleteVerificationParams;
+  export type ExternalAccountVerifyParams = ExternalAccountsAPI.ExternalAccountVerifyParams;
 }