Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media control widget suggestions #6

Closed
Dubzer opened this issue Jul 29, 2020 · 24 comments
Closed

Media control widget suggestions #6

Dubzer opened this issue Jul 29, 2020 · 24 comments
Assignees
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed Known issue Known Bug UI/UX Related to appearance of the app and flyout.

Comments

@Dubzer
Copy link

Dubzer commented Jul 29, 2020

HI. I just built new version from sources and it looks great! But you made a single media control widget with switches. Should we expect an option to switch between old and new variation in future versions? IMO the old one was quite handy when you have a lot of screen space

image

image

Also, it might be reasonable to hide a three dots button when additional player options are not available.

image

@ShankarBUS
Copy link
Member

ShankarBUS commented Jul 29, 2020

Well I wanted it to be similar to Windows 10X's UI. So instead of creating a separate UI, I recreated the Windows 10X Media control UI.

Windows 10X media UI

And I won't change my decision about this. (Would be consistent with win 10 once it's UI is updated)

Scrolling vertically would take up a lot of the available screen space and my be irritating to users with small displays.

And for the "three dots button" it could be hidden (later) if no options are available.

I'm not adamant of this decision but some decisions like this have to be made and the users must be let go choose what they what. If enough people vote for the old UI, you may expect a comeback of it. I'm currently tight on schedule. So that's it

@Dubzer
Copy link
Author

Dubzer commented Jul 29, 2020

We may have had a misunderstanding, so I made this concept:

concept

So I'm not suggesting returning the old style.

Scrolling vertically would take up a lot of the available screen space and my be irritating to users with small displays.

I don't mean scrolling, but statically positioned. And because of small displays I suggest to make it optional. Something like "Always show all media sources", and it would switch between current behavior and suggested.

Anyway, thank you for your job!

@ShankarBUS
Copy link
Member

ShankarBUS commented Jul 30, 2020

Hey @Dubzer, so you want to keep the new UI but need an option to show multiple session controls vertically and not one at a time in horizontal.

That could be done, it would be a nice little feature. It's also easy to be done.

Edit :

How many card do you want to show before scroll buttons appear? The old UI had a max-height of 198 and will show scroll buttons when expanded above that.

@Dubzer
Copy link
Author

Dubzer commented Jul 31, 2020

It would be great if it was calculated according to screen height. But as it will require an additional work, I think 2, or maybe 3 is enough

@ShankarBUS ShankarBUS added the Enhancement New feature or request label Aug 29, 2020
@ShankarBUS ShankarBUS self-assigned this Aug 29, 2020
@ShankarBUS ShankarBUS added the Good First Issue Good for newcomers label Aug 29, 2020
@ShankarBUS ShankarBUS added this to To do in v1.0 via automation Sep 2, 2020
@ShankarBUS ShankarBUS added Help Wanted Extra attention is needed Known issue Known Bug UI/UX Related to appearance of the app and flyout. labels Sep 16, 2020
@ShankarBUS ShankarBUS added this to the 0.6 milestone Sep 20, 2020
Samuel12321 added a commit that referenced this issue Sep 21, 2020
@ShankarBUS ShankarBUS removed this from the 0.6 milestone Sep 22, 2020
@prakharb5 prakharb5 mentioned this issue Sep 27, 2020
@ShankarBUS
Copy link
Member

Hey @Sameul12321, since this feature will require changes in settings (i.e. reorg). Can you move this issue from v0.7 project to v0.8?

@ShankarBUS
Copy link
Member

Hey @Dubzer, the ability to auto hide the "More Controls" button has been added in 8754e25

The 1st half of this request is postponed to v0.8 😅. But please be patient until your request is implemented.

@Samuel12321
Copy link
Member

Hey @Sameul12321, since this feature will require changes in settings (i.e. reorg). Can you move this issue from v0.7 project to v0.8?

sure

@Samuel12321 Samuel12321 added this to To do in v0.8.0 via automation Sep 27, 2020
ShankarBUS added a commit that referenced this issue Oct 18, 2020
- Animated Scrolling
- Support for vertical stacking and scrolling
- Base implementation for #6
v1.0 automation moved this from To do to Done Oct 18, 2020
v0.8.0 automation moved this from To do to Done Oct 18, 2020
@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 18, 2020

@Dubzer,

Sorry for taking too long (~3 months) to implement this 😅.
And thank you so much for proposing this idea ✌.

Your proposal has been implemented in 7e587f1

image

Currently the settings window is messed up, so all options are placed on a single page. I'm working on reorganizing it.
There won't be a 2px gap between those media controls like it used to in v0.2.0

The highest number of media controls that can be shown vertically is currently 10. Should I increase this?

I hope I did what you wanted.

If you're still willing to use this app, wait till v0.8 is released. Feel free to propose new ideas 👍 😁

@Samuel12321
Copy link
Member

definitely think the gap is needed.

@ShankarBUS
Copy link
Member

Would you guys shut up now?

image

Could you see the 8px spacing?

@Samuel12321
Copy link
Member

Would you guys shut up now?

Sorry?

@ShankarBUS
Copy link
Member

I was joking 😂. Do you guys like it?

@Samuel12321
Copy link
Member

Sorry, i misinterpreted your statement.

Yes, it will be a good feature to have.

ShankarBUS added a commit that referenced this issue Oct 19, 2020
Complete implementation of #6 i.e. added spacing in vertical layout.
@prakharb5
Copy link
Member

Can we also reduce it to 1? And what's the behaviour, say I set it to 2, but I have 3 media sources. What will be the behaviour for that?

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 19, 2020

It will show scroll buttons if the controls are more than the max count.

Why are you even confused about this 🤣? The terminology apparently 😅.

Any suggestion for the sentence to show there?

I added the ability to switch between vertical and horizontal stacking. Only the vertical layout will have spacing and the ability to show multiple session controls.

@prakharb5
Copy link
Member

Any suggestion for the sentence to show there?

I didn't get you. What sentence?

@ShankarBUS
Copy link
Member

What should be the header for the new vertical media controls count option?

Currently it is Maximum Number of Media Session Controls vertically. It seems to be confusing. We need a replacement for that.

Any suggestions?

@prakharb5
Copy link
Member

prakharb5 commented Oct 19, 2020

I think Maximum media session controls

I say we hide this setting or grey it out when horizontal mode is selected.

@ShankarBUS
Copy link
Member

No we shouldn't (we can but we shouldn't). They are independent of each other and should be independently controllable.

I added vertically to reduce confusion.

What about Maximum Number of Media Session Controls to show vertically then?

If you still insist on disabling it while choosing Horizontal, we can do that.

@prakharb5
Copy link
Member

prakharb5 commented Oct 19, 2020

I am getting a bit confused. Lets clear one point. Is this feature for multiple flyouts available in horizontal mode?

@ShankarBUS
Copy link
Member

Is this feature for multiple flyouts available in horizontal mode?

No, that's I've been saying all along

@Samuel12321
Copy link
Member

I agree with @Cyberdroid1, the current terminology can be confusing. i personally think the option to select the maximum number of vertical media controls should be disabled or hidden when set to horizontal. Otherwise it seems like this feature also occurs horizontally.

@ShankarBUS
Copy link
Member

Ok that's cool, we already need to update some sentences to make them clean and professional.

We can do this together with that.

Hey @Samuel12321, we are getting translation PRs at unwanted times, what should we do?

Let's say i introduce a temporary string like the previously mentioned one, people are updating the translations even for the temporary strings.

It is hard to maintain consistency across the resx files. The commit history will be unnecessarily filled. I am still confused about the past PRs, would they even work? Why merge them if they don't work?

How should they help us with multilingual support?

How and when should we accept translation PRs?

What about the xlf files & Multilingual App Toolkit?

@Samuel12321
Copy link
Member

Found out how to make them work.
Regarding translation PR's i will review them and merge them when it suits.

ShankarBUS added a commit that referenced this issue Oct 21, 2020
- Animated Scrolling
- Support for vertical stacking and scrolling
- Base implementation for #6
ShankarBUS added a commit that referenced this issue Oct 21, 2020
Complete implementation of #6 i.e. added spacing in vertical layout.
ShankarBUS added a commit that referenced this issue Oct 21, 2020
- Animated Scrolling
- Support for vertical stacking and scrolling
- Base implementation for #6
ShankarBUS added a commit that referenced this issue Oct 21, 2020
Complete implementation of #6 i.e. added spacing in vertical layout.
ShankarBUS added a commit that referenced this issue Oct 22, 2020
- Animated Scrolling
- Support for vertical stacking and scrolling
- Base implementation for #6
ShankarBUS added a commit that referenced this issue Oct 22, 2020
Complete implementation of #6 i.e. added spacing in vertical layout.
@Samuel12321 Samuel12321 added this to To do in 0.7.5 Oct 23, 2020
@Samuel12321 Samuel12321 moved this from To do to Done in 0.7.5 Oct 23, 2020
@Samuel12321 Samuel12321 removed this from Done in v0.8.0 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed Known issue Known Bug UI/UX Related to appearance of the app and flyout.
Projects
No open projects
0.7.5
Done
v1.0
  
Done
Development

No branches or pull requests

4 participants