Improve inline SVG detection #1553
Conversation
|
@eltonmesquita - I thought you said you did not want to run both checks? |
|
Sorry, I've got a bit confused by your answer. But still, I think it is a better option, as it will not return any false positive, like the current test. If it is to be documented, where exactly this info should be? I don't see anything related to this kind of issue in the docs. |
|
we usually add a |
| @@ -7,8 +7,12 @@ | |||
| "notes": [{ | |||
| "name": "Test page", | |||
| "href": "http://paulirish.com/demo/inline-svg" | |||
| }, { | |||
| "name: "Test page and results", | |||
There was a problem hiding this comment.
you have a typo here that is breaking the parsing and thus the tests
"name: should be "name":
There was a problem hiding this comment.
Sorry for that, ended up missing it. Fixed!
|
Could you squish down everything to a single commit? then we can get this landed :D |
|
Did I do it right, now? I don't know why the AppVeyour build failed, but it doesn't seem to be a problem with the code itself... |
|
appveyor is shakey - it messed up during the npm install. I kicked off the build again, just to double check. |
|
you would want to run |
|
Did I get it now? Got to take a course on git... |
|
@eltonmesquita seems like it got messed up :[ sorry again for complicated things. I cherrypicked and merged in via 71e9e73 thanks a ton for the PR! |
|
No problem, this mess happened because I lacked some Git skills and time to review everything, it wasn't your fault. Next time I contribute, I'll do it in a clean way! |
|
👍 On Fri, May 1, 2015, 2:02 PM Elton Mesquita notifications@github.com
|
Fix issue #1552