Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom storage #19

Closed
Modernizr opened this issue Nov 9, 2009 · 5 comments
Closed

dom storage #19

Modernizr opened this issue Nov 9, 2009 · 5 comments

Comments

@Modernizr
Copy link
Collaborator

http://github.com/fearphage/Modernizr/commit/fe68e0cb88e05067daeb4163bc263d37a11ad965
tests[domstorage] = function() {
// tested sessionsStorage this way because otherwise Firefox will throw
return !!(window.localStorage && ('sessionStorage' in window));
};

@paulirish
Copy link
Member

this would be a revision of : http://github.com/Modernizr/Modernizr/issues/closed#issue/3

@paulirish
Copy link
Member

fwiw pilgrim refers to this as "HTML5 storage": http://diveintohtml5.org/detect.html
and his test only considers localstorage

the spec calls it Web Storage: http://dev.w3.org/html5/webstorage/

I think they should be tested together (as above) and available as
Modernizer.webstorage

@KuraFire
Copy link
Member

KuraFire commented Dec 1, 2009

I agree. It's called Web Storage because it encompasses multiple forms of storage, most notably localStorage and sessionStorage. We should test against both and report on both individually, e.g.:

Modernizr.localstorage
Modernizr.sessionstorage

(note the consistent-to-Modernizr use of all-lowercase attributes)

@Modernizr
Copy link
Collaborator Author

definitely keep them separate. chromium currently only implements localstorage:
http://24ways.org/2009/breaking-out-the-edges-of-the-browser
http://code.google.com/p/chromium/issues/detail?id=4360

@Modernizr
Copy link
Collaborator Author

sessionStorage and 'x' in window fix for cookies-disabled. closed by 1e0ba91

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants