Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizr CSS VMIN #2238

Open
longridge opened this issue Aug 24, 2017 · 2 comments
Open

Modernizr CSS VMIN #2238

longridge opened this issue Aug 24, 2017 · 2 comments

Comments

@longridge
Copy link

Within a couple of websites I've written, I test for css feature VMIN - using modernizr 3.5.0.

With android chrome and ipad (safari) - Modernizr identifies VMIN as fine - i.e. a positive test when in portrait mode - but the same test applied to same browser in landscape mode fails. (Chrome on IPAD is recognised whether portrait or landscape). IS this an issue for the modernizr test ie what is modernizr checking to identify the support for VMIN?
Issue can be seen by reference to music website http://www.northfyldemusiccircle.org.uk and "inspecting" the css tests supported by modernizr.

@everget
Copy link

everget commented Sep 27, 2017

@longridge

what is modernizr checking to identify the support for VMIN?

feature-detects/css/vminunit.js

@longridge
Copy link
Author

The full test I use (built around an "if else" statement) is :

Modernizr.mq("only all") && Modernizr.cssvwunit && Modernizr.cssremunit && Modernizr.flexbox && Modernizr.boxsizing && Modernizr.cssvminunit && Modernizr.mediaqueries

The key feature which seems to cause a problem (in circumstances covered earlier) is
"Modernizr.cssvminunit"

Code can be seen using web inspector tools on site referred to in opening note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants