Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon API breaks build #2303

Closed
stordoff opened this issue Mar 24, 2018 · 2 comments
Closed

Beacon API breaks build #2303

stordoff opened this issue Mar 24, 2018 · 2 comments

Comments

@stordoff
Copy link

Calling Modernizr via:
<script src="js/vendor/modernizr-3.6.0.custom.min.js"></script>

When Modernizr is built using https://modernizr.com/download/?-beacon-localstorage-video-webp-addtest-setclasses-shiv, Modernizr fails to load with the following issue:

modernizr-3.6.0.custom.min.js:3 Uncaught ReferenceError: define is not defined at modernizr-3.6.0.custom.min.js:3

Adjusting to https://modernizr.com/download/?-localstorage-video-webp-addtest-setclasses-shiv (i.e. removing the Beacon API) works fine.

This also applies to the development build https://modernizr.com/download?do_not_use_in_production

Tested in latest Chrome; can be replicated in Firefox as well.

@rejas
Copy link
Member

rejas commented May 25, 2018

Seems to be aproblem with the download-builder at modernizr.com since manually building it works for me but using the builder over there doesnt. Could you open an issue at https://github.com/Modernizr/modernizr-neue ?

@rejas
Copy link
Member

rejas commented Jun 12, 2018

Opened issue at Modernizr/modernizr-neue#126 closing this one.

@rejas rejas closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants