Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionStorage test issue #423

Closed
Deschtex opened this issue Dec 2, 2011 · 2 comments
Closed

sessionStorage test issue #423

Deschtex opened this issue Dec 2, 2011 · 2 comments

Comments

@Deschtex
Copy link
Contributor

Deschtex commented Dec 2, 2011

Hey!

Watching the code of Modernizr v2.1pre I notice you have different tests for localStorage and sessionStorage.
The test for sessionStorage will return true even in Safari's private browsing mode. That's not correct, as web
storage is prohibited in that mode and will throw a "QUOTA_EXCEEDED_ERRROR DOM Exception 22" exception.

However, the test for localStorage is correct and will return false, and the same test should be applied to sessionStorage.
@paulirish
Copy link
Member

Thank you. :)

Good call. You can either do a pull req or I'll get to this later.

@paulirish
Copy link
Member

closed by #424

npmcomponent pushed a commit to npmcomponent/componentizr-modernizr that referenced this issue Jan 8, 2014
@Deschtex
https://github.com/Modernizr/Modernizr/issues/423
22c6779 
I changed the test for sessionStorage to the same test as for localStorage, 
fixing the issue described in the thread linked above.
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@Deschtex
https://github.com/Modernizr/Modernizr/issues/423
e5e2e15 
I changed the test for sessionStorage to the same test as for localStorage, 
fixing the issue described in the thread linked above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @Deschtex