Modernizr.touch changes, as per #548 #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I think the modulizr folder can pretty much go away in this new world, if I'm remembering correctly. Ashamed that I didn't have auto-whitespace removal when I wrote that file. |
SlexAxton
added a commit
that referenced
this pull request
Jan 29, 2013
Modernizr.touch changes, as per #548
|
I think |
|
Touch screen via a KVM which hasn't been switched over? And for the sake of future-proofing, who knows what people will come up with in the future... we thought they'd always have a mouse. |
|
(I'm aware I'm probably being overly cautious...) |
|
fair enough it's not overly complicated test and like you said it's more robust than just checking |
|
Of course keyboard-only is perfectly valid too! |
SlexAxton
added a commit
to SlexAxton/Modernizr
that referenced
this pull request
Feb 14, 2013
Modernizr.touch changes, as per Modernizr#548
Closed
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Modernizr.touch changes, as per Modernizr#548
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Modernizr.touch changes, as per Modernizr#548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizr.touch changes, as per #548:
Modernizr.touch->Modernizr.touchevent(buttouchstill aliased)Modernizr.pointerevents(CSS pointer-events) ->Modernizr.csspointereventsModernizr.pointereventsAPI-breaking change.
I've done the PointerEvents test by checking for presence of the
pointerdownevent. Microsoft's recommendation is to usewindow.navigator.pointerEnabled(prefixed), but it isn't clear ifpointerEnabledis intended to change dynamically as devices are connected/disconnected... anyone know? We agreed on #548 that Modernizr should focus on static capability to support pointer events, not dynamic state of whether or not an appropriate device is connected.Review please!