Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS-19: add cf s3 bucket #21

Merged
merged 20 commits into from
Aug 27, 2018
Merged

OAS-19: add cf s3 bucket #21

merged 20 commits into from
Aug 27, 2018

Conversation

facundovictor
Copy link
Contributor

@facundovictor facundovictor commented Aug 20, 2018 •
edited
Loading

This PR includes:

  • Add support for CREATE/DELETE/GET Stack (missing update for now)
  • Add support for monitoring Stack changes
  • Add support for creating and deleting the base s3 bucket (used for storing nested stack templates)
  • Fix for the AWS SDK config load

TODO for this PR:

  • Add inline descriptions for each function
  • Update README
  • Add UPDATE Stack
  • Add check for if the s3 bucket needs to be created/updated

@facundovictor facundovictor self-assigned this Aug 20, 2018
@facundovictor facundovictor changed the title WIP: OAS-19: add cf s3 bucket OAS-19: add cf s3 bucket Aug 27, 2018
@rpigu-i rpigu-i self-requested a review August 27, 2018 15:50
rpigu-i
rpigu-i approved these changes Aug 27, 2018
View reviewed changes
Copy link
Collaborator

@rpigu-i rpigu-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - let's standardized the comment format across the JS files. I don't think we need to do this immediately, but would be good to have some consistency going forwards.

@facundovictor
Copy link
Contributor Author

facundovictor commented Aug 27, 2018 •
edited
Loading

Tanks @rpigu-i !
Yes, I agree, and also we can start adding a linter and some tests. Let's merge it for now so others can start contributing with that and other features as well from this base.

@facundovictor facundovictor merged commit 3076e53 into master Aug 27, 2018
@facundovictor facundovictor deleted the feature/OAS-19-add-cf-s3-bucket branch August 27, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpigu-i rpigu-i rpigu-i approved these changes

Assignees

@facundovictor facundovictor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@facundovictor @rpigu-i