Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS-20 push code #26

Merged
merged 81 commits into from
Sep 14, 2018
Merged

OAS-20 push code #26

merged 81 commits into from
Sep 14, 2018

Conversation

rpigu-i
Copy link
Collaborator

@rpigu-i rpigu-i commented Sep 12, 2018

Handles:

  1. Kicking off the CodeBuild CI pipeline
  2. Accepting parameters from a JSON files and/or the commandline
  3. Checking code out of GitHub
  4. Migrating code into S3 Bucket.

TODO:

  1. Cache invalidation for CloudFront
  2. Review mechanism that injects commands into CloudBuild and see if this approach works for MVP
  3. Review DNS versus EMail for Cert manager
  4. Add logic to ensure specified flags override commandline params and parameters in a config file.
  5. Init command wrapper for all the separate steps.

N.B The order of precedence is:

Specified flags > key/values in site_config parameter > key/values in file defined by site_config_file parameter

e.g.

--dom example.com > --site_config {"dom": "example.com" } > --site_config_file mydomainconfig.json

@rpigu-i rpigu-i requested a review from grgur September 13, 2018 21:00
@grgur grgur merged commit 8977d77 into master Sep 14, 2018
@grgur grgur deleted the OAS_20_push_code branch September 14, 2018 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants