Feature/certificates cloudformation template #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundovictor
approved these changes
Jun 14, 2018
| DomainName: !Ref "Domain" | ||
| DomainValidationOptions: | ||
| - DomainName: !Ref "Domain" | ||
| ValidationDomain: !Ref "Domain" |
There was a problem hiding this comment.
For the DomainName, we may also want to have another parameter for if we want to setup a certificate to protect all subdomains under that DomainName (wilcard).
Also, the SubjectAlternativeNames would be useful if the page would require to be accessed by an alternative domain.
There was a problem hiding this comment.
Sounds good. Did some reading up on this last night. I'll merge this in and we can then apply these changes today.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this in for review/discussion.
I've created a separate file for the certificate manager stuff as well so we can start to split this out if we are happy with it. If so I'll add the file and push to this branch.