Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic formatting: eslint, prettier, pre-commit hook #75

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

ikovic
Copy link
Contributor

@ikovic ikovic commented Nov 3, 2019

Set up prettier and eslint with neutral (recommended) ruleset. I've ran the formatter across the codebase, so there's a large diff, but the actual changes are few - just removed a couple of unused variables.

Added guidelines for contributors with explained prettier and eslint integration.

Resolves #66

@ikovic ikovic added enhancement New feature or request MVP2 MVP2 tasks labels Nov 3, 2019
@ikovic ikovic requested a review from rpigu-i November 3, 2019 16:26
@ikovic ikovic self-assigned this Nov 3, 2019
@ikovic ikovic added this to In progress in Capsule via automation Nov 3, 2019
@ikovic ikovic marked this pull request as ready for review November 3, 2019 16:45
Capsule automation moved this from In progress to Reviewer approved Nov 4, 2019
Copy link
Collaborator

@rpigu-i rpigu-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for these updates.

@rpigu-i rpigu-i merged commit 8914255 into ModusCreateOrg:master Nov 4, 2019
Capsule automation moved this from Reviewer approved to Done Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MVP2 MVP2 tasks
Projects
Capsule
  
Done
Development

Successfully merging this pull request may close these issues.

Automatic formatting
2 participants