Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating step 3 config file usage #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bronz3beard
Copy link

resolves #160

ReadMe.md update
This step is added for clarity on being able to use the config file

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull request type

Docs update

Please check the type of change your PR introduces:

  • Documentation content changes

Does this introduce a breaking change?

  • Yes
  • No

Other information

None

This step is added for clarity on being able to use the config file
@mitchellsimoens
Copy link
Collaborator

This shouldn't be needed as here in the code, we look for the config file. The glob that is used is .gimbalrc.{js,json,yaml,yml} and it's using the cwd which defaults to process.cwd() (where you executed the command at). Instead of updating the docs, the bug would need to be found and fixed instead.

@bronz3beard
Copy link
Author

@mitchellsimoens
Do you know if there is a way I can use the same approach re --config ./filelocation in the github action?
I know this is not the desired approach but I would really like to show the usage for gimbal on our GH PRs to the team. Just as a temp fix?
If not all good I just wanted to ask. 😃

@mitchellsimoens
Copy link
Collaborator

@bronz3beard the entrypoint of the gimbal action is gimbal which means you can use a step's with to add additional args: https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gimbalrc.yml in root folder being ignored
2 participants