-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Gadget/prism): 新的代码高亮工具 #443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generateGadgetsDefinition
…generateGadgetsDefinition
我应该fork这个分支吗?或者也可以先合掉,我再提交后续pr。 |
佬你可以直接在这里改,看pr最开头的说明操作就行了 如果要引入站外代码的话最好是参考其他文件用prefetch或者browserify |
我没有这个分支的写入权限。 |
那你fork这个分支提pr吧 |
有办法测试吗?还是说先限制一下权限合掉好方便测试? |
我觉得可以? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bhsd-harry 佬,看看这个,能不能把你那个parser整合进这里来
如果可以整合的话,先把以下内容删掉:
MoegirlPediaInterfaceCodes/scripts/prefetch/targets.yaml
Lines 171 to 178 in ecc3878
然后把这个文件删掉:https://github.com/MoegirlPediaInterfaceAdmins/MoegirlPediaInterfaceCodes/blob/feat/prism/src/gadgets/prism-language-wiki/.eslintrc.yaml
就可以在src/gadgets/prism-language-wiki里写了