Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Software Keyboard Input #40

Closed
Moehammered opened this issue Oct 7, 2021 · 0 comments
Closed

[Refactor] Software Keyboard Input #40

Moehammered opened this issue Oct 7, 2021 · 0 comments
Assignees
@Moehammered
Labels
enhancement New feature or request
Projects
Switch Remote Play - Road to version 1.0
Milestone
v1.0

Comments

@Moehammered
Copy link
Owner

Moehammered commented Oct 7, 2021 •
edited
Loading

Currently, there are a lot of settings the users can configure on the Switch. Some of these settings are numbers that have a large range (the AMD codec has quantisation settings that range from -1 to 61 for example).

To mitigate this issue (and future issues for configuration settings), input by the user will be taken via the software keyboard to improve convenience.

User stories

  • When the user presses 'A' on a number value setting, the software keyboard will open the numpad and let the user enter a number.
    • When the user puts a number that is not within range, the keyboard will re-open to let the user enter a number again
    • When the user cancels the keyboard, a default value will be used instead
  • When the user presses 'A' on a string value setting, the software will open the normal or QWERTY keyboard and let the user enter a string
    • When the user puts a string that is not applicable, the keyboard will re-open to let the user enter a string again
    • When the user cancels the keyboard, a default value will be used instead

Settings to be moved over to software keyboard input

  • All number entry settings (except bitrate, framerate, and resolution)
    • Desktop resolution may be considered but this could lead to user issues being reported about failed desktop resolution change issues or even streams failing to connect or start.
    • Framerate may be considered.
  • IP network configuration settings

Everything else will maintain usage of the circulators in use already when A or B are pressed.
@Moehammered Moehammered added the enhancement New feature or request label Oct 7, 2021
@Moehammered Moehammered self-assigned this Oct 7, 2021
Moehammered added a commit that referenced this issue Oct 7, 2021
@Moehammered
[Refactor - Numbers via Software Keyboard] #40
78f60d9 
Implemented a templated software keyboard method to allow opening the keyboard to accept and parse user input.

User input can be validated as well via a predicate.

Some number based settings have been modified to use the new software keyboard method now. This can be seen for Thread Count and Mouse Sensitivity.

Some menus will need to be modified to be able to use the software keyboard and the network configuration menu needs to be overhauled.

Max thread count for the decoder menu was decreased to a sensible(but still high) value to stop users from completely crippling performance unknowingly.
@Moehammered Moehammered added this to the v1.0 milestone Oct 7, 2021
@Moehammered Moehammered mentioned this issue Oct 9, 2021
Closed
Moehammered added a commit that referenced this issue Oct 9, 2021
@Moehammered
[Refactor - Network Configuration Menu] #40 closes #41
40f639b 
Network configuration menu rewritten to follow the configuration patterns of the other menus.

Now all network related settings can be modified via the software keyboard.

It might be a good idea to reduce the number of ports used.
Moehammered added a commit that referenced this issue Oct 10, 2021
@Moehammered
[Refactor - Monitor Number via Keyboard] #40 closes #21
1d2151b 
Monitor selection is now done via the software keyboard implementation.

Users can now configure which monitor is chosen for streaming.
@Moehammered Moehammered moved this from In progress to Done in Switch Remote Play - Road to version 1.0 Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moehammered Moehammered

Labels
enhancement New feature or request
Projects
Switch Remote Play - Road to version 1.0
Done
Milestone
v1.0
Development

No branches or pull requests
1 participant
@Moehammered