Skip to content

Commit

Permalink
Update to PyLint 2.5 and fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Moguri committed May 22, 2020
1 parent 5740e69 commit 7d94f50
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .pylintrc
Expand Up @@ -7,11 +7,11 @@ extension-pkg-whitelist=

# Add files or directories to the blacklist. They should be base names, not
# paths.
ignore=
ignore=git

# Add files or directories matching the regex patterns to the blacklist. The
# regex matches against base names, not paths.
ignore-patterns=
#ignore-patterns=

# Python code to execute, usually for sys.path manipulation such as
# pygtk.require().
Expand Down
5 changes: 2 additions & 3 deletions gltf/viewer.py
@@ -1,9 +1,9 @@
import math
import os
import sys

from direct.showbase.ShowBase import ShowBase
import panda3d.core as p3d
from math import tan, radians

import simplepbr

Expand Down Expand Up @@ -46,8 +46,7 @@ def __init__(self):
radius = bounds.get_radius()

fov = self.camLens.get_fov()
distance = radius / tan(radians(min(fov[0], fov[1]) / 2.0))
idealFarPlane = distance + radius * 1.5
distance = radius / math.tan(math.radians(min(fov[0], fov[1]) / 2.0))
self.camLens.set_near(min(self.camLens.get_default_near(), radius / 2))
self.camLens.set_far(max(self.camLens.get_default_far(), distance + radius * 2))
trackball = self.trackball.node()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -18,7 +18,7 @@
],
tests_require=[
'pytest',
'pylint==2.4.*',
'pylint~=2.5.0',
'pytest-pylint',
],
entry_points={
Expand Down

0 comments on commit 7d94f50

Please sign in to comment.