resolves #633 Introduce PUPPETEER_PRINT_TIMEOUT for puppeteer pdf rendering #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Mar 10, 2022
ggrossetie
reviewed
Mar 10, 2022
siaccarino
commented
Mar 10, 2022
| @@ -89,10 +89,14 @@ async function convert (processor, inputFile, options, timings, watch, preview) | |||
| } | |||
| try { | |||
| const page = await browserInstance.goto(`file://${tempFile}`, preview) | |||
| const puppeteerDefaultTimeout = process.env.PUPPETEER_DEFAULT_TIMEOUT | |||
There was a problem hiding this comment.
could be taken from browser instance but in terms of dependency reduction this might be better
siaccarino
changed the title
siaccarino
changed the title
siaccarino
changed the title
|
Looks good! As mentioned in #612 (comment) it would be better to create a separate 'TIP' for each timeout but for now it's good enough. We can revisit this logic later in a follow-up pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request #236 did not change the puppeteer rendering timeout - it changes the time asciidoc-web-pdf waits for puppeteer.
According to puppeteer pdf options a timeout shall be passed to the page.pdf() call instead.
Rendering of complex documents on slow machines could easily exceed the 30s limit.
Solution: Introduce a PUPPETEER_PRINT_TIMEOUT environment variable that is passed to puppeteer - see puppeteer pdf timeout option.
Issue: #633