Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #633 Introduce PUPPETEER_PRINT_TIMEOUT for puppeteer pdf rendering #632

Merged
merged 3 commits into from
Mar 10, 2022
Merged

resolves #633 Introduce PUPPETEER_PRINT_TIMEOUT for puppeteer pdf rendering #632

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d14b6ad
Fix the pull request #236
Mar 9, 2022
41ea9cb
review findings. introduce PUPPETEER_PRINT_TIMEOUT
Mar 10, 2022
a67782f
update TIP
Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,14 @@ async function convert (processor, inputFile, options, timings, watch, preview)
}
try {
const page = await browserInstance.goto(`file://${tempFile}`, preview)
const puppeteerDefaultTimeout = process.env.PUPPETEER_DEFAULT_TIMEOUT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be taken from browser instance but in terms of dependency reduction this might be better

const printTimeout = process.env.PUPPETEER_PRINT_TIMEOUT || puppeteerDefaultTimeout || 30000

if (!preview) {
const pdfOptions = {
printBackground: true,
preferCSSPageSize: true
preferCSSPageSize: true,
timeout: printTimeout
}
const pdfWidth = doc.getAttributes()['pdf-width']
if (pdfWidth) {
Expand Down