Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tigrinya (ትግርኛ) language translation: #181

Closed
wants to merge 1 commit into from

Conversation

oyd11
Copy link

@oyd11 oyd11 commented Apr 5, 2020

More on Issue #142 , hopefully closing it, and production ready.

  • locale 'ti' (iso 639-1 and locale code)
  • Using the English prompts as the source for translation
  • Translation contributed by Araya Kassa. I have basic knowledge of Tigrinya, enough to verify most of this, it seems like a good translation in context, the translator has background in the healthcare system, and is a native speaker of Tigrinya.
  • npm test passed successfully.
  • npm start runs successfully, but I did not test this yet.

 * locale 'ti' (iso 639-1 and locale code)
 * Using the English prompts as the source for translation
 * Translator remains anonymous for now, I had basic knowledge of Tigrinya, enough to verify most of this, it seems like a good translation in context, the translator has background in the healthcare system, and is a native speaker of Tigrinya.
 * `npm test` passed successfully.
 * `npm start` runs successfully, but I did not test this yet.
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #181 into master will not change coverage by %.
The diff coverage is 22.22%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #181   +/-   ##
======================================
  Coverage    8.68%   8.68%           
======================================
  Files          57      57           
  Lines        1888    1888           
  Branches      376     376           
======================================
  Hits          164     164           
  Misses       1577    1577           
  Partials      147     147           
Impacted Files Coverage Δ
src/actions/LocaleActions.ts 0.00% <0.00%> (ø)
src/components/Loading.tsx 0.00% <ø> (ø)
src/components/Main/ExposureInstructions.tsx 0.00% <0.00%> (ø)
src/components/Main/ScanHome.tsx 0.00% <ø> (ø)
src/components/Onboarding/AllSet.tsx 0.00% <ø> (ø)
src/components/common/ChangeLanguage.tsx 0.00% <0.00%> (ø)
src/components/common/ChangeLanguageButton.tsx 0.00% <ø> (ø)
src/components/common/GeneralWebview.tsx 0.00% <ø> (ø)
src/components/common/Text.tsx 0.00% <ø> (ø)
src/reducers/LocaleReducer.ts 38.46% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694714f...65f8a56. Read the comment docs.

@oyd11
Copy link
Author

oyd11 commented Apr 5, 2020

I've closed PR #156 by mistake (after some rebase error I had, wanted to keep this up-to-date with master).

@oyd11
Copy link
Author

oyd11 commented Apr 8, 2020

Translation was reviewed by native speaker volunteer from the "Eritrean Women's Community Center in Israel" [ https://www.eritreanwomenscenter.org ].
I suggest this is iterated into the next release, along with some explanation, it was just reported that two foreign-nationals in Southern-Tel-Aviv, were diagnosed with COVID-19, which is one of the denser Tigrinya-speaking population in Israel right now. Thank you.

@oyd11
Copy link
Author

oyd11 commented May 18, 2020

Can anyone merge this translation? It's verified since 5th-April-2020 (a little over a month),
and there's still a highly dense urban population which speaks this language predominantly, a lot of them working in the service industry now. Please merge.

Note that the Minister - does release Videos in Tigrinya : (Tigrinya subtitles in this case) :
מיגון פנים - טיגרית
https://www.youtube.com/watch?v=dEYbG5nrXZw

@kaplanlior kaplanlior added the translations Translations of the UI to other languages. label Jun 2, 2020
@kaplanlior
Copy link
Member

Hi @oyd11 , thanks for this PR and your effort. At the moment we don't accept any new translations. I'm adding a translations tag to this PR, so it could be used easily when translations would be accepted again.

@kaplanlior kaplanlior closed this Jun 2, 2020
@sltanhs
Copy link

sltanhs commented Feb 7, 2023

حسبي الله ونعم الوكيل منك يا ابو بشار المنحرف الغدار الخاين المخادع الكذاب ليش عادك تحلف من كذب وهذا ماهو زنوه

@sltanhs
Copy link

sltanhs commented Feb 7, 2023

حسبي الله ##ونعم الوكيل منك يا ابو بشار المنحرف الغدار الخاين المخادع الكذاب ليش عادك تحلف من كذب وهذا ماهو

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the UI to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants