Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Folder - push history #53

Closed
7 tasks done
MohamedBakoush opened this issue Nov 8, 2021 · 2 comments · Fixed by #60
Closed
7 tasks done

Folder - push history #53

MohamedBakoush opened this issue Nov 8, 2021 · 2 comments · Fixed by #60
Assignees
@MohamedBakoush
Labels
enhancement New feature or request

Comments

@MohamedBakoush
Copy link
Owner

MohamedBakoush commented Nov 8, 2021 •
edited

Push folder path to history isn't available making refresh page or pressing presses previous page unable to work properly when the user is accessing the desired folder.

  • Push folder by id to history - pushNewFolderIDToFolderIDPath
  • Reset history to /saved/videos if previous url path wasn't /saved/videos - resetInsideFolderID
  • Push multiple folder ids to history - newfolderIDPath
  • Invalid Folder path, display main (/saved/videos)
  • if error return undefined - getAvailableVideoDetailsByFolderPath
  • display main or specified folder path - eachAvailableVideoDetails
  • Fix 2 click previous page limitation bug
@MohamedBakoush MohamedBakoush added the enhancement New feature or request label Nov 8, 2021
@MohamedBakoush MohamedBakoush self-assigned this Nov 8, 2021
@MohamedBakoush
Copy link
Owner Author

MohamedBakoush commented Nov 17, 2021 •
edited

Bug: At /saved/videos pressing the previous page is limited to 2 times first click goes to the previous folder, the other goes to /saved/videos, then either it stops allowing the previous page to be activated or it goes back and forward between /saved/videos and last folder destination.

@MohamedBakoush MohamedBakoush added the bug Something isn't working label Nov 17, 2021
@MohamedBakoush
Copy link
Owner Author

Bug fixed - 4ac8ef2

@MohamedBakoush MohamedBakoush linked a pull request Nov 21, 2021 that will close this issue
Folder push history #60
Merged
@MohamedBakoush MohamedBakoush removed the bug Something isn't working label Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MohamedBakoush MohamedBakoush

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Folder push history MohamedBakoush/WatchVideoByLink
1 participant
@MohamedBakoush