Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 68 #70

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Fix issue 68 #70

merged 5 commits into from
Jun 5, 2023

Conversation

MohamedLamineAllal
Copy link
Owner

Issue #68

- It's no more the case with this fix. And warning only is logged.
- And that's the reasonable behavior as empty folders are
expected. And not matching. It shouldn't block processes.
- latest pnpm version no more support node v14 on github workflow
@MohamedLamineAllal MohamedLamineAllal self-assigned this Jun 5, 2023
@MohamedLamineAllal MohamedLamineAllal requested review from mertasan and removed request for mertasan June 5, 2023 13:55
@coveralls
Copy link

coveralls commented Jun 5, 2023

Pull Request Test Coverage Report for Build 5177777963

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 23 (52.17%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 65.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Utils/Logger/index.ts 3 8 37.5%
src/MixGlob/CallProcessors/ArgSrcGlobs/index.ts 2 8 25.0%
Totals Coverage Status
Change from base Build 4455191454: -1.0%
Covered Lines: 274
Relevant Lines: 402

💛 - Coveralls

@MohamedLamineAllal MohamedLamineAllal merged commit ce08480 into master Jun 5, 2023
9 checks passed
@MohamedLamineAllal MohamedLamineAllal deleted the fix-issue-68 branch June 7, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants