-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decodeHtml4 & decodeHtml5 in one step #18
Comments
|
It does not. The following test case fails for HTML5: @Test fun decode() {
assertEquals("Å", KsoupEntities.decodeHtml4("Å"))
assertEquals("Å", KsoupEntities.decodeHtml5("Å"))
} |
It's a bug. I'll check this |
I'll release a new version soon containing the fix for this issue and the other issues as well. |
decodeHtml5
isn't a set which also contains thedecodeHtml4
entities. I'd like to invoke both. I know that I can call them one after another however, but I'm guessing performance wise a single call would be better. Since it'd only need to loop once instead of twice over the string. AlsoNumericEntityDecoder()
is used twice which is unnecessary.Esentially, I want an aggregator like this:
Side note: I also found
decodeHtml
confusing as at first I thought this is decode4+5 but it's just 5, in which case, I'd go for removing that method to make the API smaller & conciser.The text was updated successfully, but these errors were encountered: