Fix up small issues in readme #6

ire4ever1190 · 2023-05-17T05:08:52Z

Was following the readme to test out the lib (cool library 🎉) but ran into a few small problems in the readme

Using input which doesn't exist instead of html
Using a builder when a handler was needed instead (The first instance of this isn't a bug, but the variable was called "handler" so assumed you would want a handler instead of a builder)

- Using nonexistant `input` variable instead of `html` (This also happened in later section) - Assigning a builder to a handler variable (Not an issue, but semantically it makes sense to build it) - Trying to pass a builder instead of a built instance

MohamedRejeb

Thanks for your contribution

Fix up small issues

7c965ba

- Using nonexistant `input` variable instead of `html` (This also happened in later section) - Assigning a builder to a handler variable (Not an issue, but semantically it makes sense to build it) - Trying to pass a builder instead of a built instance

MohamedRejeb self-requested a review May 17, 2023 10:33

MohamedRejeb approved these changes May 17, 2023

View reviewed changes

MohamedRejeb merged commit 72363c8 into MohamedRejeb:main May 17, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix up small issues in readme #6

Fix up small issues in readme #6

ire4ever1190 commented May 17, 2023

MohamedRejeb left a comment

Fix up small issues in readme #6

Fix up small issues in readme #6

Conversation

ire4ever1190 commented May 17, 2023

MohamedRejeb left a comment

Choose a reason for hiding this comment