Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings request. #138

Open
ghost opened this issue Feb 21, 2017 · 9 comments
Open

Typings request. #138

ghost opened this issue Feb 21, 2017 · 9 comments
Milestone

Comments

@ghost
Copy link

ghost commented Feb 21, 2017

Typings would be really helpful, as we use alertifyjs in our typescript project.

@MohammadYounes
Copy link
Owner

I intend to do a complete re-write using typescript, but still can't find the time!

@MohammadYounes MohammadYounes added this to the 2.0.0 milestone Feb 26, 2017
@MohammadYounes
Copy link
Owner

@AloeDream Check out these typings.

@odrozd
Copy link

odrozd commented Mar 22, 2017

@MohammadYounes, thanks for typing link, guess its ok for basic shape, but it would be great to get full library typing experience with information about different options and method and underling types especially when creating custom dialogs.

@apratheek
Copy link

@MohammadYounes Any update on the typings? The link mentioned seems to be dead. Any help would be appreciated.

@MohammadYounes
Copy link
Owner

@apratheek Seems the author deleted the repo.

It's still on my todo list. But, unfortunately I can't find the time to do it.

@CoskunSunali
Copy link

Sad, we have to switch to another library for this reason...

@henryruhs
Copy link

henryruhs commented Dec 11, 2018

@CoskunSunali @apratheek @AloeDream

1. General approach

  1. Create a global.d.ts including declare var alertify: object;
  2. Add the typings file global.d.ts to your TypeScript configuration
  3. Instead of object you could define a interface including all the functions

Did not try it, but that just it...

2. DefinitelyTyped approach

npm install --save @types/alertify

See: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/alertify

@henryruhs
Copy link

@MohammadYounes Issue could be closed I think

@MohammadYounes
Copy link
Owner

@redaxmedia Why? we are still missing detailed typings - @types/alertify is for the old alertify.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants