Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistant logging #48

Closed
yaacov opened this issue Dec 1, 2017 · 0 comments · Fixed by #61
Closed

Consistant logging #48

yaacov opened this issue Dec 1, 2017 · 0 comments · Fixed by #61
Assignees
@boaz0
Labels
enhancement logging

Comments

@yaacov
Copy link
Member

yaacov commented Dec 1, 2017

In the code we sometimes use fmt [1] other time log [2] , we need to use log consistantly throw the code.

For example this two snippets are equivalent:

fmt.Println(err)
os.Exit(1)

log.Fatal(err)

[1] https://github.com/MohawkTSDB/mohawk/blob/master/main.go#L28
[2] https://github.com/MohawkTSDB/mohawk/blob/master/api/server.go#L204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boaz0 boaz0

Labels
enhancement logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use fmt instead of log MohawkTSDB/mohawk
2 participants
@yaacov @boaz0