nested-folders-support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kha333n, thank you for the PR have you tested this out regarding the export too? because i really don't have time to write test for this or test it myself |
|
No i didn't write test cases. Manually tested import and export. But not zip export. Me too busy at the time. But will do ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for nested folders
No one in big project is going to add loot of files in single folder. They will use nested folders.
This update read file and get its relative path to language folder and stores complete path.
Then it can change and update translations for those and also exports to the same relative path in each language folder.
It may not be the best way to do that but I did it according to my need. If anything needs to update, you can ping me.
@MohmmedAshraf