Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unmount cleanup of Facets #12

Merged
merged 9 commits into from
Nov 5, 2021
Merged

Fix unmount cleanup of Facets #12

merged 9 commits into from
Nov 5, 2021

Commits on Nov 5, 2021

  1. WIP: adding tests and implementing cleanup

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    abb0016 View commit details
    Browse the repository at this point in the history

  2. Temporary “benchmark” screen to validate when removeChild is called 

    I’ve verified that for keyed lists, React does not call removeChild to change the order in a list. It simply calls `insertInContainerBefore`.

More info: https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore:

> If the given node already exists in the document, insertBefore() moves it from its current position to the new position. (That is, it will automatically be removed from its existing parent before appending it to the specified new parent.)
    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9173dae View commit details
    Browse the repository at this point in the history

  3. Removing console.log

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    411c7cf View commit details
    Browse the repository at this point in the history

  4. Initial cleanup implementation

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    8203c45 View commit details
    Browse the repository at this point in the history

  5. Tests that all properties are being cleanup

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    780f21b View commit details
    Browse the repository at this point in the history

  6. Remove temporary test screen

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    2ac012a View commit details
    Browse the repository at this point in the history

  7. Better document the test

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3098869 View commit details
    Browse the repository at this point in the history

  8. Fix portal test

    @pirelenito
    pirelenito committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dae3922 View commit details
    Browse the repository at this point in the history

  9. Update packages/@react-facet/dom-fiber/src/types.ts 

    Co-authored-by: Fernando Via Canel <fernando.via@gmail.com>
    @pirelenito @xaviervia
    pirelenito and xaviervia committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    309a734 View commit details
    Browse the repository at this point in the history